From 169daa11155988a210fac949297381743f3cb400 Mon Sep 17 00:00:00 2001
From: Kacper <kacper@mail.openlinux.dev>
Date: Tue, 9 Dec 2025 23:14:53 +0100
Subject: feat: clang-tidy fixes

---
 lib/libc/time/asctime.c             |  4 ++--
 lib/libc/time/clock.c               |  4 ++--
 lib/libc/time/clock_getcpuclockid.c |  6 +++---
 lib/libc/time/clock_getres.c        |  6 ++++--
 lib/libc/time/clock_nanosleep.c     |  6 ++++--
 lib/libc/time/ctime.c               |  2 +-
 lib/libc/time/difftime.c            |  4 ++--
 lib/libc/time/gmtime_r.c            |  2 +-
 lib/libc/time/localtime.c           |  2 +-
 lib/libc/time/localtime_r.c         |  2 +-
 lib/libc/time/nanosleep.c           |  6 ++++--
 lib/libc/time/strftime.c            | 27 ++++++++++++++++-----------
 lib/libc/time/time.c                |  5 ++---
 lib/libc/time/tzset.c               |  6 ++++--
 lib/libc/time/utimes.c              | 11 ++++++-----
 15 files changed, 53 insertions(+), 40 deletions(-)

(limited to 'lib/libc/time')

diff --git a/lib/libc/time/asctime.c b/lib/libc/time/asctime.c
index ab5ff096..0bf76cb2 100644
--- a/lib/libc/time/asctime.c
+++ b/lib/libc/time/asctime.c
@@ -1,5 +1,5 @@
-#include <time.h>
-#include <stdio.h>
+#include <stdio.h> // for snprintf
+#include <time.h>  // for tm, asctime
 
 char *asctime(const struct tm *timeptr)
 {
diff --git a/lib/libc/time/clock.c b/lib/libc/time/clock.c
index ec2e6084..50cc4a6e 100644
--- a/lib/libc/time/clock.c
+++ b/lib/libc/time/clock.c
@@ -1,5 +1,5 @@
-#include <time.h>
-#include <limits.h>
+#include <limits.h> // for LONG_MAX
+#include <time.h>   // for timespec, clock_gettime, CLOCK_PROCESS_CPUTIME_ID
 
 clock_t clock(void)
 {
diff --git a/lib/libc/time/clock_getcpuclockid.c b/lib/libc/time/clock_getcpuclockid.c
index 5bb53221..a0f10b8a 100644
--- a/lib/libc/time/clock_getcpuclockid.c
+++ b/lib/libc/time/clock_getcpuclockid.c
@@ -1,5 +1,5 @@
-#include <time.h>
-#include <syscall.h>
+#include <syscall.h> // for __syscall_2, syscall
+#include <time.h>    // for clockid_t, clock_getcpuclockid, pid_t
 
 int clock_getcpuclockid(pid_t pid, clockid_t *clock_id)
 {
@@ -7,7 +7,7 @@ int clock_getcpuclockid(pid_t pid, clockid_t *clock_id)
 	clockid_t id;
 	struct timespec ts;
 
-	id = (-pid - 1) * 8U + 2;
+	id = (clockid_t)((-pid - 1) * 8U + 2);
 	ret = syscall(clock_getres, id, &ts);
 
 	if (ret >= 0) {
diff --git a/lib/libc/time/clock_getres.c b/lib/libc/time/clock_getres.c
index 5af37e8d..9eac94ef 100644
--- a/lib/libc/time/clock_getres.c
+++ b/lib/libc/time/clock_getres.c
@@ -1,5 +1,7 @@
-#include <time.h>
-#include <syscall.h>
+
+
+#include <syscall.h> // for __syscall_2, syscall
+#include <time.h>    // for clock_getres, clockid_t
 
 int clock_getres(clockid_t clock_id, struct timespec *res)
 {
diff --git a/lib/libc/time/clock_nanosleep.c b/lib/libc/time/clock_nanosleep.c
index 63190d06..0722963f 100644
--- a/lib/libc/time/clock_nanosleep.c
+++ b/lib/libc/time/clock_nanosleep.c
@@ -1,5 +1,7 @@
-#include <time.h>
-#include <syscall.h>
+
+
+#include <syscall.h> // for __syscall, __syscall_4
+#include <time.h>    // for clock_nanosleep, clockid_t
 
 int clock_nanosleep(clockid_t clock_id, int flags, const struct timespec *rqtp,
 		    struct timespec *rmtp)
diff --git a/lib/libc/time/ctime.c b/lib/libc/time/ctime.c
index bddd30cf..989ddcfc 100644
--- a/lib/libc/time/ctime.c
+++ b/lib/libc/time/ctime.c
@@ -1,4 +1,4 @@
-#include <time.h>
+#include <time.h> // for asctime, localtime, ctime, time_t
 
 char *ctime(const time_t *clock)
 {
diff --git a/lib/libc/time/difftime.c b/lib/libc/time/difftime.c
index e7b567c1..e25e6e15 100644
--- a/lib/libc/time/difftime.c
+++ b/lib/libc/time/difftime.c
@@ -1,6 +1,6 @@
-#include <time.h>
+#include <time.h> // for time_t, difftime
 
 double difftime(time_t time1, time_t time0)
 {
-	return time1 - time0;
+	return (double)(time1 - time0);
 }
diff --git a/lib/libc/time/gmtime_r.c b/lib/libc/time/gmtime_r.c
index 2c741127..47dbd105 100644
--- a/lib/libc/time/gmtime_r.c
+++ b/lib/libc/time/gmtime_r.c
@@ -1,4 +1,4 @@
-#include <time.h>
+#include <time.h> // for tm, time_t, gmtime_r
 
 struct tm *gmtime_r(const time_t *timer, struct tm *result)
 {
diff --git a/lib/libc/time/localtime.c b/lib/libc/time/localtime.c
index 44029920..530c0f26 100644
--- a/lib/libc/time/localtime.c
+++ b/lib/libc/time/localtime.c
@@ -1,4 +1,4 @@
-#include <time.h>
+#include <time.h> // for localtime_r, localtime, time_t, tm
 
 struct tm *localtime(const time_t *timer)
 {
diff --git a/lib/libc/time/localtime_r.c b/lib/libc/time/localtime_r.c
index 1fb620a4..04c04509 100644
--- a/lib/libc/time/localtime_r.c
+++ b/lib/libc/time/localtime_r.c
@@ -1,4 +1,4 @@
-#include <time.h>
+#include <time.h> // for gmtime_r, time_t, localtime_r, timezone
 
 struct tm *localtime_r(const time_t *restrict timer, struct tm *restrict result)
 {
diff --git a/lib/libc/time/nanosleep.c b/lib/libc/time/nanosleep.c
index f5c5f7c9..2d433248 100644
--- a/lib/libc/time/nanosleep.c
+++ b/lib/libc/time/nanosleep.c
@@ -1,5 +1,7 @@
-#include <time.h>
-#include <syscall.h>
+
+
+#include <syscall.h> // for __syscall_2, syscall
+#include <time.h>    // for nanosleep
 
 int nanosleep(const struct timespec *rqtp, struct timespec *rmtp)
 {
diff --git a/lib/libc/time/strftime.c b/lib/libc/time/strftime.c
index 3f54961b..e1078dd8 100644
--- a/lib/libc/time/strftime.c
+++ b/lib/libc/time/strftime.c
@@ -1,6 +1,8 @@
-#include <time.h>
-#include <libc.h>
-#include <string.h>
+#include "features.h" // for __weak
+
+#include <libc.h>   // for __unused
+#include <string.h> // for strlcpy, strlen
+#include <time.h>   // for tm, size_t, locale_t, strftime, strftime_l
 
 static size_t append_string(char *restrict *s, size_t *remaining,
 			    const char *str)
@@ -34,15 +36,18 @@ static size_t format_int(char *restrict *s, size_t *remaining, int value,
 	*ptr = '\0';
 
 	int negative = 0;
+	unsigned int uvalue;
 	if (value < 0) {
 		negative = 1;
-		value = -value;
+		uvalue = (unsigned int)(-value);
+	} else {
+		uvalue = (unsigned int)value;
 	}
 
 	do {
-		*--ptr = '0' + (value % 10);
-		value /= 10;
-	} while (value > 0);
+		*--ptr = (char)('0' + (uvalue % 10));
+		uvalue /= 10;
+	} while (uvalue > 0);
 
 	if (negative) {
 		*--ptr = '-';
@@ -50,9 +55,9 @@ static size_t format_int(char *restrict *s, size_t *remaining, int value,
 		*--ptr = '+';
 	}
 
-	int len = (buffer + sizeof(buffer) - 1) - ptr;
+	size_t len = (size_t)((buffer + sizeof(buffer) - 1) - ptr);
 
-	while (len < width) {
+	while ((int)len < width) {
 		*--ptr = pad;
 		len++;
 	}
@@ -497,8 +502,8 @@ size_t strftime(char *restrict s, size_t maxsize, const char *restrict format,
 				sign = '-';
 				offset = -offset;
 			}
-			int hours = offset / 3600;
-			int minutes = (offset % 3600) / 60;
+			int hours = (int)(offset / 3600);
+			int minutes = (int)((offset % 3600) / 60);
 			if (!append_char(&s, &remaining, sign) ||
 			    !format_int(&s, &remaining, hours, 2, '0', 0) ||
 			    !format_int(&s, &remaining, minutes, 2, '0', 0)) {
diff --git a/lib/libc/time/time.c b/lib/libc/time/time.c
index 134eed7b..3f8848a8 100644
--- a/lib/libc/time/time.c
+++ b/lib/libc/time/time.c
@@ -1,6 +1,5 @@
-#include <time.h>
-#include <asm/vdso.h>
-#include <syscall.h>
+#include <asm/vdso.h> // for __vdso_time
+#include <time.h>     // for timespec, clock_gettime, time_t, CLOCK_REALTIME
 
 time_t time(time_t *tloc)
 {
diff --git a/lib/libc/time/tzset.c b/lib/libc/time/tzset.c
index 96f33702..eeb1d247 100644
--- a/lib/libc/time/tzset.c
+++ b/lib/libc/time/tzset.c
@@ -1,5 +1,7 @@
-#include <time.h>
-#include <ctype.h>
+#include "stddef.h" // for NULL
+
+#include <ctype.h> // for isdigit
+#include <time.h>  // for daylight, timezone, tzname, tzset
 
 int daylight = 0;
 long timezone = 0;
diff --git a/lib/libc/time/utimes.c b/lib/libc/time/utimes.c
index 7b928e7a..af644481 100644
--- a/lib/libc/time/utimes.c
+++ b/lib/libc/time/utimes.c
@@ -1,8 +1,9 @@
-#include <fcntl.h>
-#include <errno.h>
-#include <stddef.h>
-#include <sys/stat.h>
-#include <sys/time.h>
+#include <errno.h>    // for EINVAL, errno
+#include <fcntl.h>    // for AT_FDCWD
+#include <stddef.h>   // for NULL
+#include <sys/stat.h> // for utimensat
+#include <sys/time.h> // for timeval, utimes
+#include <time.h>     // for timespec
 
 int utimes(const char *path, const struct timeval times[2])
 {
-- 
cgit v1.2.3